Re: [PATCH net] selftests/drivers/net: include lib/sh/*.sh

[Matthieu Baerts]

Hi Hangbin,

On 07/09/2026 09:28, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@xxxxxxxxxx>
> 
> When I tried to install and run bonding selftests via:
> 
>   make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/bonding \
>      -C tools/testing/selftests install
> 
> Some tests fail because net/lib/sh/defer.sh is missing:
> 
>   /tmp/kself/net/forwarding/../lib.sh: line 5: /tmp/kself/net/lib/sh/defer.sh: No such file or directory
> 
> One option is to add defer.sh directly to TEST_INCLUDES. Alternatively,
> follow the approach from commit f72aa1b27628 ("selftests: net: include
> lib/sh/*.sh with lib.sh"), which pulls in all .sh files to accommodate
> future changes to the library directory.
> 
> This patch adds a wildcard to include all shell files for drivers/net
> tests that consume net lib.sh. TEST_INCLUDES is also sorted to avoid
> ordering‑related problems for future modifications. The team driver is
> not affected by this bug, but we use the wildcard for it as well, rather
> than listing only defer.sh.
Thank you for fixing that!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.