Re: [PATCH] mm/huge_memory: bypass THP tuneables for huge pfnmap mappings

[David Hildenbrand (Arm)]

>> 1. is vma_allow_thp_tuneables_file() better? Then all three helpers are
>> vma + a verb + thp_tuneables_file().
> 
> That's a good idea! Much better thanks.
> 
>>
>> 2. is vma_file_ a better prefix than putting file at the end?
> 
> Yeah, it's an annoying one as kinda want to say 'file-backed VMA' but I think
> you're right vma_xxx_file() -> vma_file_xxx() is better.
> 
> Andrew - could you fix that up in place?
> 
> Obviously if there's further feedback I can respin as well.

Just as a general note I really hate these in-place updates.

For a reviewer perspective (like me stumbling over this) this is just a mess.

Resending with b4 is as easy as it gets.

-- 
Cheers,

David