Re: [PATCH 1/2] staging: octeon: fix use-after-free in tasklet teardown

From: Greg KH

Date: Mon Sep 07 2026 - 12:35:46 EST


On Sat, Sep 05, 2026 at 09:05:29PM +0530, Ayush Mukkanwar wrote:
> cvm_oct_tx_shutdown() kills the tx cleanup tasklet while
> the net devices are still registered. This could lead
> to use-after-free when a tasklet is scheduled after the
> tasklet_kill() is called which might run after the net
> devices are freed.
> Fix it by unregistering the net devices before the tasklet
> is killed.
>
> Fixes: 4898c560103f ("Staging: Octeon: Free transmit SKBs in a timely manner")
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://sashiko.dev/#/message/20260615172734.42038-1-ayushmukkanwar%40gmail.com
> Signed-off-by: Ayush Mukkanwar <ayushmukkanwar@xxxxxxxxx>
> ---
> Note: This patch has only been compile tested. No runtime testing was
> performed as I do not have access to Octeon hardware.

Please wait until you have the hardware, as the sashiko review comments
say there are still issues with this patch series :(

thanks,

greg k-h