Re: [PATCH] staging: greybus: fix missing newline in sysfs_emit() format strings

From: Greg Kroah-Hartman

Date: Mon Sep 07 2026 - 12:38:20 EST


On Mon, Sep 07, 2026 at 10:15:25AM +0300, tuxdevv wrote:
> From: Deniz Gözen <denizgozen61@xxxxxxxxx>
>
> The show functions for the audio module's name, vid, pid, intf_id,
> ip_devices and op_devices sysfs attributes pass format strings to
> sysfs_emit() without a trailing newline. Per sysfs conventions each
> attribute should return content terminated by '\n', and checkpatch.pl
> flags all six calls as missing the terminator.
>
> Add the missing '\n' to each format string.
>
> Signed-off-by: Deniz Gözen <denizgozen61@xxxxxxxxx>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Please see the mailing list archives for why this change can't be
accepted at the moment.

thanks,

greg k-h