[PATCH v2 7/9] drm/tyr: refactor new_dummy_object to use new_object
From: Ke Sun via B4 Relay
Date: Mon Sep 07 2026 - 12:54:52 EST
From: Alvin Sun <alvin.sun@xxxxxxxxx>
new_dummy_object() duplicated the BO creation code that new_object()
now provides; call new_object() instead.
Signed-off-by: Alvin Sun <alvin.sun@xxxxxxxxx>
Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
---
drivers/gpu/drm/tyr/gem.rs | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/tyr/gem.rs b/drivers/gpu/drm/tyr/gem.rs
index 0e0989a48678f..2523d05de5527 100644
--- a/drivers/gpu/drm/tyr/gem.rs
+++ b/drivers/gpu/drm/tyr/gem.rs
@@ -57,7 +57,6 @@ fn new(_dev: &TyrDrmDevice, _size: usize, args: BoCreateArgs) -> impl PinInit<Se
pub(crate) type Bo = gem::shmem::Object<BoData>;
/// Create a new GEM buffer object.
-#[expect(dead_code)]
pub(crate) fn new_object(ddev: &TyrDrmDevice, size: usize, flags: u32) -> Result<ARef<Bo>> {
if size == 0 {
return Err(EINVAL);
@@ -84,17 +83,8 @@ pub(crate) fn lookup_handle(file: &TyrDrmFile, handle: u32) -> Result<ARef<Bo>>
/// Creates a dummy GEM object to serve as the root of a GPUVM.
pub(crate) fn new_dummy_object(ddev: &TyrDrmDevice) -> Result<ARef<Bo>> {
- let bo = Bo::new(
- ddev,
- 4096,
- shmem::ObjectConfig {
- map_wc: true,
- parent_resv_obj: None,
- },
- BoCreateArgs { flags: 0 },
- )?;
-
- Ok(bo)
+ // FIXME: use a Rust resv-object abstraction once available, rather than a real BO.
+ new_object(ddev, PAGE_SIZE, 0)
}
/// Specifies how to choose a GPU virtual address for a [`KernelBo`].
--
2.43.0