Re: [PATCH v2 4/7] block: honor IOCB_NOWAIT in the block device buffered read path

[Tal Zussman]

On 9/7/26 10:11 AM, Christoph Hellwig wrote:
>> +	if (iocb->ki_flags & IOCB_NOWAIT) {
>> +		if (!inode_trylock_shared(bd_inode)) {
>> +			if (!ret)
>> +				ret = -EAGAIN;
>> +			goto reexpand;
>> +		}
>> +	} else {
>> +		inode_lock_shared(bd_inode);
>> +	}
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> Do we want something like kiocb_inode_lock/kiocb_inode_lock_shared helper
> to better encapsulate this pattern?
> 

Seems like it's fairly common (~16 instances). I can do that eventually as
a follow-up.

Thanks,
Tal