Re: [PATCH v3] leds: rgb: leds-qcom-lpg: Add PWM frequency mode support

[Fenglin Wu]

On 9/3/2026 11:30 PM, Lee Jones wrote:
>> Certain PWM channels on a PMIC (e.g. PM8350C PWM4) support a Frequency
>> Mode (FM) that can generate waveforms with more frequency points than
>> the standard LPG PWM mode. The trade-off is that the duty cycle can
>> only be fixed at 50%. Add the FM support. When the PWM channel is
>> requested to set a duty cycle to exactly 50%, use FM mode by default
>> as it provides a finer-grained frequency resolution in that case.
>>
>> Also, guard mutex lock at the top of lpg_pwm_get_state(), to make the
>> register read atomic against the register write in lpg_pwm_apply().

> Would it be better to split this submission into two separate patches? One to
> address the locking in 'lpg_pwm_get_state()' and another to introduce the new
> Frequency Mode support.
> 

Sure, thanks. I’ll split them out and submit them as a series.

Do you think if I need to combine below change in the same series, even
though they are not functionally dependent?

https://lore.kernel.org/linux-leds/20260716-lpg-rgb-color-balance-fix-v6-1-b49d51528f61@xxxxxxxxxxxxxxxx/