Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640

[Colin Huang]

Conor Dooley <conor@xxxxxxxxxx> 於 2026年9月8日週二 上午1:01寫道：
>
> On Mon, Sep 07, 2026 at 03:03:29PM +0800, Colin Huang wrote:
> > From: Colin Huang <u8813345@xxxxxxxxx>
> >
> > Add Device Tree compatible strings for Renesas RAA229639 and
> > RAA229640 PMBus devices.
>
> Driver change suggests fallback compatibles could be used.
> Why aren't they? If they can be, add them. Otherwise, explain why not in
> your commit message.
>
> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
Hi Conor
  Thanks for the review.

  I didn't add a fallback compatible because I only have document for
RAA229639 and RAA229640
  and could not verify full DT level compatibility with any existing
supported devices. While both devices
  are handled by the existing raa_dmpvr2_2rail driver variant, I don't
have sufficient information to establish
  a compatible fallback relationship.

  I will clarify this in commit message in v2.

Thanks.
Colin
> >
> > Signed-off-by: Colin Huang <u8813345@xxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > index 8216cdf758d8..3537c7ddfb09 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > @@ -60,6 +60,8 @@ properties:
> >            - renesas,raa229001
> >            - renesas,raa229004
> >            - renesas,raa229621
> > +          - renesas,raa229639
> > +          - renesas,raa229640
> >
> >        - items:
> >            - enum:
> >
> > --
> > 2.34.1
> >