Re: [PATCH 3/3] arm64: dts: qcom: Add Lenovo IdeaPad Slim 5x 14Q8X9

[Konrad Dybcio]

On 9/8/26 7:18 AM, Jens Glathe wrote:
> Hi Konrad,
> 
> On 07.09.26 11:14, Konrad Dybcio wrote:
>> On 9/6/26 2:22 PM, Jens Glathe via B4 Relay wrote:
>>> From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
>>>
>>> Add a common DTSI plus LCD and OLED board files for the Lenovo
>>> IdeaPad Slim 5 14Q8X9 (machine type 83HL) on X1P42100. In some
>>> regions this SKU is sold as "IdeaPad Slim 5x"; the "x" is the
>>> Qualcomm suffix in Lenovo's current IdeaPad naming (i = Intel,
>>> a = AMD, x = Qualcomm).

[...]

>>> +        vreg_l4b_1p8: ldo4 {
>>> +            regulator-name = "vreg_l4b_1p8";
>>> +            regulator-min-microvolt = <1800000>;
>>> +            regulator-max-microvolt = <1800000>;
>>> +            regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>> +
>>> +            regulator-state-mem {
>>> +                regulator-on-in-suspend;
>>> +            };
>> Why is this necessary?
> 
> I had a debug session on the Thinkbook 16 with Grok where I chased stuck mouse via USB dongle after long suspend. This is what resulted from this, PTN3222 losing its state on deep suspend when the vreg shuts off. And it solved the problem, propagated it over to the Ideapad 5 device trees. I also observed that on the Ideapad 5 2in1 before. Never seen on the Slim5x, but I got that one after the change was in. So, yes, IMO.

Alright, let's at least leave a comment for the future reader

Konrad