Re: [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to AVX10_V1_AUX

[zhao1.liu]

On Tue, Sep 08, 2026 at 02:13:17PM +0800, Hao Xiang wrote:
> Date: Tue, 08 Sep 2026 14:13:17 +0800
> From: Hao Xiang <hao.xiang@xxxxxxxxxxxxxxxxx>
> Subject: [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to
>  AVX10_V1_AUX
> X-Mailer: [Alimail-Mailagent][W4_0.2.3][v5ForWebDing][Chrome]
> 
> CPUID feature bit AVX10_VNNI_INT is renamed to AVX10_V1_AUX to account
> for additional AVX10.2 isntructions sep-arated to have ”OR” sensitivity

nits:

s/isntructions/instructions/ - though it's a typo in spec :-(.
s/sep-arated/separated/ - there are no line breaks here.

> for platforms which may not support all of AVX10.2[*]. This CPUID bit now
> applies to the following VNNI instructions: VPDPB[SU,UU,SS]D[,S]
> VPDPW[SU,US,UU]D[,S], as well as the following convert in-structions:

s/in-structions/instructions/

> VCVT[,2]PH2[B,H]F8[,S], VCVT2PS2PHX, VCVT-BIASPH2[B,H]F8[,S],
> VCVTHF82PH.
> 
> [*]: Intel® Advanced Vector Extensions 10.2 Architecture Specification
>       (rev 7.0).
> 
> Signed-off-by: Hao Xiang <hao.xiang@xxxxxxxxxxxxxxxxx>
> ---
>   arch/x86/kvm/cpuid.c         | 2 +-
>   arch/x86/kvm/reverse_cpuid.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

I hadn't renamed it before because I thought this bit's name is not
exposed to user space, and it's enough to refer to it simply as
"this bit". But, semantically speaking, VNNI_INT is indeed no longer
correct. As noted in your commit message, the feature represented by
this bit now includes more convert instructions. And more accurate
naming is better, as it makes it easier to look up the spec.

This name change looks good to me, so

Reviewed-by: Zhao Liu <zhao1.liu@xxxxxxxxx>

And BTW, the prefix of subject should be "KVM: x86:", referring
"Shortlog" section of Documentation/process/maintainer-kvm-x86.rst.

Thanks,
Zhao