Re: [PATCH net-next v5 3/3] net: xilinx: axienet: Fix IRQ error handling
From: Simon Horman
Date: Tue Sep 08 2026 - 05:05:59 EST
On Tue, Sep 08, 2026 at 09:51:26AM +0700, Bui Duc Phuc wrote:
> >
> > Critical: 0 · High: 1 · Medium: 0 (1) · Low: 0
> >
> > - [High] Incomplete fix: the axistream-connected branch of
> > axienet_probe() still cannot request a probe retry, and this patch now…
> >
>
> irq_of_parse_and_map() has always folded every failure into plain 0,
> with no way to tell "not ready yet" from "malformed DT". Before this
> patch, that 0 was already turned into a terminal -ENOMEM, not
> -EPROBE_DEFER, so there was no retry path to begin with - this patch
> doesn't remove one, it's a pre-existing API-level limitation.
>
> > Pre-existing issues:
> > - [Medium] DT binding and driver disagree on interrupt index ordering.
> >
>
> This is a pre-existing issue, unrelated to this patch. I'll keep this
> patch's scope as is.
Thanks, agreed on both counts.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>