Re: [PATCH net-next v2] net: mvpp2: simplify IRQ validity check
From: Simon Horman
Date: Tue Sep 08 2026 - 05:14:30 EST
On Thu, Sep 03, 2026 at 02:57:53PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
> The current condition also checks for negative values, even though
> irq_of_parse_and_map() does not return negative error codes.
>
> Check only for a zero return value to match the semantics of
> irq_of_parse_and_map().
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
>
> Link v1:
> https://lore.kernel.org/all/20260824100758.31622-1-phucduc.bui@xxxxxxxxx/
>
> Changes in v2:
> - Drop the Fixes tag and rework the commit message to describe this
> as a cleanup.
> - Add net-next to the --subject-prefix.
Thanks for the updates.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>