Re: [PATCH net-next v2 2/4] dt-bindings: net: dsa: Add SoC-e SWIP switch

[Vasilij Strassheim]

On Tue, 2026-09-08 at 11:14 +0200, Krzysztof Kozlowski wrote:
> On Mon, Sep 07, 2026 at 04:01:26PM +0200, Vasilij Strassheim wrote:
> > > > +patternProperties:
> > > > +  '^(ethernet-)?ports$':
> > > 
> > > ethernet-ports
> > > 
> > > > +    patternProperties:
> > > > +      '^(ethernet-)?port@[0-9a-f]+$':
> > > 
> > > ethernet-port
> > > 
> > 
> > Is there a reason for such a restriction?
> > The pattern intentionally follows the generic DSA binding in dsa.yaml,
> 
> dsa.yaml lists ethernet-ports and port.
> 
> > which permits both ports/port@N and ethernet-ports/ethernet-port@N. The
> > device-specific pattern is needed here to apply the SoC-e port
> > constraints to both accepted node naming variants.
> 
> ports is legacy (because it conflicts with graph ports), for existing
> users, so why insisting on this pattern? If legacy is being added to new
> schemas, when are we going to be able to remove that legacy? Never.
> 

I will use ethernet-ports and ethernet-port@N instead.

Thanks for the clarification!
I was not insisting on the pattern, just wanted to understand the
reasoning behind it. I had missed that ports is legacy and followed the
generic DSA pattern and the same 10-month-old pattern in Lantiq binding.
Now I see that it is used for compatibility there and should not be
introduced in new bindings.

Best regards,
Vasilij