Re: [PATCH net-next v2 2/4] dt-bindings: net: dsa: Add SoC-e SWIP switch
From: Kurt Kanzenbach
Date: Tue Sep 08 2026 - 06:54:50 EST
On Mon Sep 07 2026, Andrew Lunn wrote:
>> > ethernet-ports
>> >
>> > > + patternProperties:
>> > > + '^(ethernet-)?port@[0-9a-f]+$':
>> >
>> > ethernet-port
>> >
>>
>> Is there a reason for such a restriction?
>> The pattern intentionally follows the generic DSA binding in dsa.yaml,
>
> You need to be careful with the DSA binding. It is old, and uses some
> things which are not considered best practices today. But they cannot
> be removed because of backwards compatibility.
Yes, exactly. When we added the dsa.yaml binding, we've had a discussion
about 'port' vs. 'ethernet-port' and had to allow both [1].
Thanks,
Kurt
[1] - https://lore.kernel.org/netdev/20200710090618.28945-1-kurt@xxxxxxxxxxxxx/
Attachment:
signature.asc
Description: PGP signature