Re: [PATCH v6 2/4] media: i2c: og0ve1b: Use monochrome-appropriate test pattern name

[Sakari Ailus]

Hi Wenmeng,

On Tue, Sep 01, 2026 at 03:40:05PM +0800, Wenmeng Liu wrote:
> OG0VE1B is a monochrome sensor and cannot produce coloured test
> patterns, so the "Vertical Colour Bars" test pattern name is misleading.
> Rename it to "Standard Test Bar" to match the OG0VA1B naming.

I guess the test pattern generator is still the same (or similar) even if
the colour filter on the sensor isn't what you'd expect of e.g. a Bayer
sensor. You you call it standard, however, I think you should define what
that standard is. We're not limited to datasheet naming here.

> 
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/og0ve1b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/og0ve1b.c b/drivers/media/i2c/og0ve1b.c
> index 84a28cdcade10f8fbcf945999e88f84641b9bc0d..da5c8e49d4a811f55736bd89c6922856f2e7391c 100644
> --- a/drivers/media/i2c/og0ve1b.c
> +++ b/drivers/media/i2c/og0ve1b.c
> @@ -72,7 +72,7 @@ struct og0ve1b_mode {
>  
>  static const char * const og0ve1b_test_pattern_menu[] = {
>  	"Disabled",
> -	"Vertical Colour Bars",
> +	"Standard Test Bar",
>  };
>  
>  static const char * const og0ve1b_supply_names[] = {
> 

-- 
Regards,

Sakari Ailus