Re: [PATCH net-next v2] net: davicom: Propagate wakeup IRQ errors

[Bui Duc Phuc]

>
> - [High] dm9000_probe() now aborts the whole probe when the *optional*
>   wakeup-IRQ setup fails.

I agree with the issues raised in the review.
Since request_irq() uses IRQF_SHARED and can fail, for example with -EBUSY,
I will address this in the next version by only propagating the
possible errors from
platform_get_irq_optional().

There will be no changes to the existing handling of request_irq() or
irq_set_irq_wake() failures.

> - [High] The newly added 'goto out' after a failing
>   irq_set_irq_wake(db->irq_wake, 1) is taken while…
>

This issue will no longer occur if we keep the existing handling for
`irq_set_irq_wake()` failures.

> Pre-existing issues:
> - [High] The wakeup IRQ requested in dm9000_probe() is never released on
>   any path other than the newly added one either: the pre-existing later…
> - [High] In dm9000_probe() the shared wakeup IRQ is requested (line 1521,
>   IRQF_SHARED, handler dm9000_wol_interrupt, dev_id = ndev) before…
> - [Low] Documentation/devicetree/bindings/net/davicom,dm9000.yaml
>   restricts 'interrupts' to 'maxItems: 1' (and defines no interrupt-…
>

These are pre-existing issues and are outside the scope of this patch.
I will leave them unchanged.