RE: [PATCH net-next 24/33] net: bcmasp: Remove comma after sentinel-entry in match-table

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> Sent: Friday, September 4, 2026 6:37 AM
> To: dario.binacchi@xxxxxxxxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx;
> mailhol@xxxxxxxxxx; msp@xxxxxxxxxxxx; florian.fainelli@xxxxxxxxxxxx;
> jonas.gorski@xxxxxxxxx; andrew@xxxxxxx; olteanv@xxxxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; kurt@xxxxxxxxxxxxx; hauke@xxxxxxxxxx;
> chester.a.unal@xxxxxxxxxx; daniel@xxxxxxxxxxxxxx;
> matthias.bgg@xxxxxxxxx; angelogioacchino.delregno@xxxxxxxxxxxxx;
> ansuelsmth@xxxxxxxxx; linusw@xxxxxxxxxx; luizluca@xxxxxxxxx;
> alvin.sipraga@xxxxxxxxxx; clement.leger@xxxxxxxxxxx;
> justin.chen@xxxxxxxxxxxx; dlan@xxxxxxxxxx; rogerq@xxxxxxxxxx;
> hkallweit1@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; rjui@xxxxxxxxxxxx;
> sbranden@xxxxxxxxxxxx; bcm-kernel-feedback-list@xxxxxxxxxxxx;
> opendmb@xxxxxxxxx; andrei.botila@xxxxxxxxxxx; wangruikang@xxxxxxxxxxx;
> amadeus@xxxxxxxxxx; kees@xxxxxxxxxx; tmshlvck@xxxxxxxxx; c-
> vankar@xxxxxx; horms@xxxxxxxxxx; vadim.fedorenko@xxxxxxxxx;
> daniel.zahka@xxxxxxxxx; nora.schiffer@xxxxxxxxxxxxxxx; v-
> singh1@xxxxxx; oss@xxxxxxxxxxxxxxx; haokexin@xxxxxxxxx;
> alex@xxxxxxxxxxxx; Loktionov, Aleksandr
> <aleksandr.loktionov@xxxxxxxxx>; lgs201920130244@xxxxxxxxx
> Cc: linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> mediatek@xxxxxxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx;
> linux-riscv@xxxxxxxxxxxxxxxxxxx; spacemit@xxxxxxxxxxxxxxx; linux-
> omap@xxxxxxxxxxxxxxx; s-vadapalli@xxxxxx
> Subject: [PATCH net-next 24/33] net: bcmasp: Remove comma after
> sentinel-entry in match-table
> 
> Since sentinel is the last entry and we do not expect further entries
> following it, remove the comma.
> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index 972474893a6b..3393b5dcbc9a 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1209,7 +1209,7 @@ static const struct of_device_id
> bcmasp_of_match[] = {
>  	{ .compatible = "brcm,asp-v2.1", .data = &v21_plat_data },
>  	{ .compatible = "brcm,asp-v2.2", .data = &v22_plat_data },
>  	{ .compatible = "brcm,asp-v3.0", .data = &v30_plat_data },
> -	{ /* sentinel */ },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, bcmasp_of_match);
> 
> @@ -1217,7 +1217,7 @@ static const struct of_device_id
> bcmasp_mdio_of_match[] = {
>  	{ .compatible = "brcm,asp-v2.1-mdio", },
>  	{ .compatible = "brcm,asp-v2.2-mdio", },
>  	{ .compatible = "brcm,asp-v3.0-mdio", },
> -	{ /* sentinel */ },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, bcmasp_mdio_of_match);
> 
> --
> 2.51.1

For me it looks like this PR doesn't clean up anything meaningful.
Is there a different opinion?