RE: [PATCH 5/7] pinctrl: renesas: rzt2h: wire up struct gpio_chip::set_config
From: Cosmin-Gabriel Tanislav
Date: Tue Sep 08 2026 - 10:55:49 EST
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, September 8, 2026 12:59 PM
>
> Hi Cosmin,
>
> On Mon, 17 Aug 2026 at 20:58, Cosmin Tanislav
> <cosmin-gabriel.tanislav.xa@xxxxxxxxxxx> wrote:
> > Wire up struct gpio_chip::set_config to allow GPIO settings via pinctrl.
> >
> > Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > --- a/drivers/pinctrl/renesas/pinctrl-rzt2h.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzt2h.c
> > @@ -1192,6 +1192,7 @@ static int rzt2h_gpio_register(struct rzt2h_pinctrl *pctrl)
> > chip->direction_output = rzt2h_gpio_direction_output;
> > chip->get = rzt2h_gpio_get;
> > chip->set = rzt2h_gpio_set;
> > + chip->set_config = gpiochip_generic_config;
> > chip->label = dev_name(dev);
> >
> > if (of_property_present(np, "interrupt-controller")) {
>
> I believe this does not depend on any of the previous patches in this
> series, so I can just queue this in renesas-pinctrl for v7.4?
>
I agree, it should be fine to pick it up independent of the rest of the
patches.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds