Re: [PATCH 2/3] w1: move slave uevent into w1_slave_device_type
From: Krzysztof Kozlowski
Date: Tue Sep 08 2026 - 11:04:56 EST
On 21/08/2026 00:54, Danilo Krummrich wrote:
> The bus-level w1_uevent() only ever added uevent variables (W1_FID,
> W1_SLAVE_ID) for slave devices.
I don't follow why only for slave. I see the w1_uevent() being part of
w1_master_driver and so on as well.
>
> Move the slave uevent logic into w1_slave_device_type.uevent where it
> naturally belongs and remove the bus-level uevent callback entirely.
>
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> ---
> Compile-tested only, no hardware available.
>
> I think the dev_dbg() stuff wasn't really useful, so I dropped it.
> ---
Best regards,
Krzysztof