Re: [PATCH net v3 2/3] net: phy: dp83td510: handle the active-high LED polarity mode

[Andrew Lunn]

On Tue, Sep 08, 2026 at 07:59:58PM +0900, Donggeun Yoo wrote:
> dp83td510_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so
> PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL.
> of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered
> so far and passes it on, and phy_probe() returns it. A device tree marking
> a DP83TD510 LED as 'active-high', which leds/common.yaml allows and
> ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device
> unbound, so phy_attach_direct() falls back to the genphy driver, which
> cannot drive this 10BASE-T1L single-mode PHY, so the interface has no
> usable link.
> 
> The callback initializes polarity to DP83TD510E_LED_POLARITY(index), which
> is the active-high setting, so the request is already satisfied and only
> the case label is missing.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 5b281fe7e396 ("net: phy: dp83td510: introduce LED framework support")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew