Re: [PATCH] platform/x86: hp-wmi: add charge_behaviour support for Spectre 8C17

[Alain Cousinie]

Le 12/08/2026 à 08:20, Shang En Sim a écrit :
> HP Spectre x360 16-aa0xxx (board 8C17) exposes battery charge mode control
> through WMI command 0x2b (GBCO/SBCO). Inhibit charge, force discharge, and
> restoring automatic charging all work through that command.
>
>   
> +#if IS_REACHABLE(CONFIG_ACPI_BATTERY)
> +static const struct dmi_system_id hp_wmi_charge_control_quirks[] __initconst = {
> +	{
> +		/* HP Spectre x360 16-aa0xxx */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "8C17"),
> +		},
> +	},
> +	{}
> +};
> +#endif
> +

Hello Shang,

I am using an HP Spectre 14-eu0xxx (board 8C15), which appears to be identical to the 8C17 model regarding `hp-wmi`.
(See also https://github.com/aigilea/hp_spectre_x360_14_eu0xxx, which also covers the 16-aa0xxx model.)
I found the same elements in the DSDT, and my tests seem to work after modifying `hp-wmi.c`.
Is it possible to add 8C15 to your patch?

+    {
+        /* HP Spectre x360 14-eu0xxx */
+        .matches = {
+            DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+            DMI_MATCH(DMI_BOARD_NAME, "8C15"),
+        },
+    },

Thanks in advance.
Alain