Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

From: Andy Shevchenko

Date: Tue Sep 08 2026 - 11:46:02 EST


On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> On Tue, 8 Sep 2026 15:41:23 +0300
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> > >
> > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > macro.
> >
> > Is this a problem?
>
> For systems using devicetree, no. For legacy systems using spi_board_info and
> this stuff, yes.
>
> If you're referring to the mark for stable then I'm fine with removing it.

No, I'm trying to (implicitly) tell you that the commit message misses
the answer to "why?".

--
With Best Regards,
Andy Shevchenko