Re: [PATCH net-next v5 00/12] gve: AdminQ mode related refactors

[Harshitha Ramamurthy]

On Tue, Sep 8, 2026 at 3:09 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 9/3/26 11:55 PM, Harshitha Ramamurthy wrote:
> > This series is preparing the driver for the addition of a new control
> > plane mode(MailboxQ) by commonizing and reusing as much code as possible.
> > MailboxQ is a new control plane infrastructure which uses mailbox queues.
> > This is a new control plane to communicate with the device when the driver
> > is running on bare-metal instances as well as newer versions of the device.
> >
> > This series contains 2 main changes to the gve driver's existing control
> > plane(AdminQ):
> > 1) refactor some initialization/teardown path methods to make it work for
> >    both control planes.
> > 2) add gve_ctrl_ops structure to the driver for various control plane
> >    operations
> >
> > The refactors are mainly around the init, reset and recover paths so that
> > functionalities could be moved into the control ops like 'set_num_queues',
> > 'set_num_ntfy_blks' etc.
> >
> > This patch series only sets the control ops for AdminQ mode. This is
> > intended as a preparation for adding MailboxQ mode in upcoming series
> > which will add the new control plane infrastructure and then introduce
> > the corresponding control ops for MailboxQ mode.
> >
> > The entire list of future patches can be found here for reference:
> > https://github.com/hramamurthy12/linux/commits/gve-mailbox-queues/
> Imho the 'medium' severity issues raised by clashiko on patches 1 should
> be addressed in this same series.
>

Will fix in v6.

> Please note that you are supposed to act on sashiko reviews, see commit
> c82ff94592fb68f529afe63ca7f5ddb7dae4ba83. Lacking such feedback, I'll
> tend to err on the safe side - i.e. requesting a new revision.

Acknowledged.

Thanks,
Harshitha

>
> /P
>