Re: [PATCH v3] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells

From: Guenter Roeck

Date: Tue Sep 08 2026 - 12:14:54 EST


On Wed, Sep 02, 2026 at 03:54:00AM +0200, Vincent Jardin wrote:
> From: Vincent Jardin <vjardin@xxxxxxx>
>
> Since commit
> a3b61ba2558e ("hwmon: (tmp401) register with thermal subsystem")
> the driver sets HWMON_C_REGISTER_TZ, so the hwmon core calls
> devm_thermal_of_zone_register() for every temperature channel and the
> device can be referenced as a thermal sensor.
>
> Signed-off-by: Vincent Jardin <vjardin@xxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
> Changes in v3:
> - Rewrite the commit message: justify the property from the driver,
> which sets HWMON_C_REGISTER_TZ since a3b61ba2558e
> (Krzysztof Kozlowski)
> - Keep "const: 1": every chip in this binding has at least two
> temperature channels, see national,lm90.yaml
> - No change to the diff/code
> - Link to v2: https://lore.kernel.org/r/20260825-for-upstream-dt-tmp401-vcc-tsc-v2-1-cbc360ec51d9@xxxxxxx
>
> Changes in v2:
> - Drop vcc-supply: tmp401.c has no regulator code, every hwmon binding
> that declares vcc-supply today has a driver consuming it, so declaring it
> as description only does not belong to this patch (Sashiko)
> - Adapt the commit message
> - Link to v1: https://lore.kernel.org/r/20260824-for-upstream-dt-tmp401-vcc-tsc-v1-1-ecb5ef7898bd@xxxxxxx
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> ---
> base-commit: 89a312991dc6e638a36adc43ccb91dbc25504c04
> change-id: 20260824-for-upstream-dt-tmp401-vcc-tsc-a16bec8352e4
>
> Best regards,
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> index 0e8ddf0ad7890..f283b567d5b6c 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> @@ -50,6 +50,9 @@ properties:
> minimum: 0
> maximum: 15
>
> + "#thermal-sensor-cells":
> + const: 1
> +
> allOf:
> - if:
> properties: