Re: [PATCH 1/2] hwmon: (asus_rog_ryujin) Validate HID report lengths

From: Guenter Roeck

Date: Tue Sep 08 2026 - 12:53:50 EST


On Thu, Sep 03, 2026 at 10:21:28PM -0400, Arie Miller wrote:
> rog_ryujin_raw_event() parses response headers and payload fields without
> first checking that they are present in the received report. A short report
> can therefore make the driver consume uninitialized bytes from the HID
> transport buffer and expose them as sensor values through sysfs.
>
> Validate the response header and the fields used by each response type
> before parsing them.
>
> Fixes: ed3e03790c5c ("hwmon: Add driver for ASUS ROG RYUJIN II 360 AIO cooler")
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-hwmon/20260812104617.858D01F000E9@xxxxxxxxxxxxxxx/
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: Codex:gpt-5.6-sol sparse
> Signed-off-by: Arie Miller <renari@xxxxxxxxxx>

Applied.

Thanks,
Guenter