Re: [PATCH v7 0/3] perf tools: port UI from GTK2 to GTK4

[Ian Rogers]

On Sun, Sep 6, 2026 at 2:05 PM Matt Turner <mattst88@xxxxxxxxx> wrote:
>
> On Sun, Sep 6, 2026 at 4:59 PM Alexei Starovoitov
> <alexei.starovoitov@xxxxxxxxx> wrote:
> >
> > On Sun, Sep 6, 2026 at 1:13 PM Matt Turner <mattst88@xxxxxxxxx> wrote:
> > >
> > > GTK2 is long dead upstream and increasingly hard to keep building on
> > > current distros. This series ports perf's GTK-based report browser to
> > > GTK4 and fixes it up so it's actually loadable at runtime after the
> > > port.
> > >
> > > Patch 1 does the mechanical port (build system, widget API changes),
> > > including the leftover-GTK2-call and signal-handling fixes that were a
> > > separate patch 3 in v4. Patch 2 fixes a runtime issue found after the
> > > port that prevented the browser from loading. Patch 3 fixes two stack
> > > buffer overflows in the hierarchy view that predate the port.
> > >
> > > Signed-off-by: Matt Turner <mattst88@xxxxxxxxx>
> > > ---
> > > Changes in v7:
> >
> > Matt, please stop the spam.
> > Wait for humans to reply before respinning.
> > 7 revisions in one day is way too much.
>
> My apologies. I figured it would actually save humans time if I went
> ahead and addressed all the sashiko-generated feedback. Dunno.
>
> Is there a way to get feedback from sashiko without mailing the public list?

TL;DR: drop bpf from the to/cc list when sending patches. This work is
most interesting to linux-perf-users where multiple versions of a
patch series within a short period of time are common.

I appreciate having the latest patches to review. If Sashiko provides
feedback, the change goes on my 'to be reviewed later' pile, which
hinders getting code/fixes landed.
It is possible to configure Sashiko to 'embargo' its feedback for a
set number of hours. Networking does this, and it can be frustrating
when you must wait for a patch to receive review before landing it. It
also slows down developers.

Sashiko isn't adopted on all mailing lists, and while it is a widely
praised, others don't want the email churn. In a year or so, when the
models are better, I imagine the churn will decrease as:
1) If AI is used to create the code then it should be better able to
predict Sashiko-like issues,
2) Sashiko itself can report all problems, suggest changes, etc.
rather than its current drip drip of issues.

Thanks for the contribution!
Ian