Re: [PATCH v11 1/2] dt-bindings: mfd: x-powers: Add AC200
From: Conor Dooley
Date: Tue Sep 08 2026 - 14:17:17 EST
On Mon, Sep 07, 2026 at 03:03:14PM -0600, James Hilliard wrote:
> The AC200 is an I2C-controlled mixed-signal companion IC containing
> audio, video, RTC and Fast Ethernet PHY functions.
>
> Describe the shared input clock, audio DAI, TV encoder display graph and
> optional bandgap calibration in one parent node. The codec and TV encoder
> do not need separate firmware nodes.
>
> AC_LDOIN and TV_VCC are distinct 3.3 V supply inputs. Describe them
> separately without requiring different external regulators. Require the
> audio supply when the DAI is described and the video supply when the
> display graph is present, while allowing PHY-only configurations.
>
> Describe the optional shared INTB connection without an internal
> interrupt domain. Cable detection status remains readable over I2C when
> INTB is not connected. Include wired and unwired examples.
>
> The Ethernet PHY is represented by a PHY package on its MDIO bus, with a
> phandle back to this device for access to the package control registers.
> It therefore does not require an MFD child node. The input clock must run
> at 24 or 27 MHz when the Ethernet PHY is used, matching the rates encoded
> by its documented clock selector.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
btw, this is kinda odd. Jernej has a signoff, but no other attribution.
Are they a coauthor missing a Co-developed-by
> ---
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable
Thanks,
Conor.
> .../devicetree/bindings/mfd/x-powers,ac200.yaml | 168 +++++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 175 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
> new file mode 100644
> index 000000000000..75dafa7c1071
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
> @@ -0,0 +1,168 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/x-powers,ac200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: X-Powers AC200 mixed-signal IC
> +
> +maintainers:
> + - James Hilliard <james.hilliard1@xxxxxxxxx>
> + - Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> +
> +description:
> + The AC200 is a mixed-signal companion IC containing audio, video, RTC and
> + Fast Ethernet PHY functions. Its control registers are accessed over I2C.
> + The audio codec and TV encoder are described by properties of this node.
> + The Ethernet PHY is described separately on its MDIO bus.
> +
> +allOf:
> + - $ref: /schemas/sound/dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: x-powers,ac200
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description:
> + AC200 input clock. When using the Ethernet PHY, its configured rate must
> + be 24 or 27 MHz, matching the rates encoded by the documented EPHY clock
> + selector.
> +
> + interrupts:
> + maxItems: 1
> + description:
> + The shared, level-triggered, open-drain INTB output for the TV encoder,
> + Ethernet PHY and RTC interrupts. Omit when INTB is not connected. TV
> + encoder cable detection status can also be read over I2C without an
> + interrupt.
> +
> + '#sound-dai-cells':
> + const: 0
> +
> + ac-ldoin-supply:
> + description:
> + The 3.3 V supply connected to the AC_LDOIN pin for the audio codec LDO
> + input. This may be the same regulator as tv-vcc-supply.
> +
> + tv-vcc-supply:
> + description:
> + The 3.3 V supply connected to the TV_VCC pin for the composite-video
> + DAC. This may be the same regulator as ac-ldoin-supply.
> +
> + nvmem-cells:
> + maxItems: 1
> + description: TV encoder bandgap calibration.
> +
> + nvmem-cell-names:
> + items:
> + - const: bandgap
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Input to the TV encoder, carrying CCIR656.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Output to the composite-video connector.
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +dependencies:
> + '#sound-dai-cells': [ ac-ldoin-supply ]
> + ports: [ tv-vcc-supply ]
> + nvmem-cells: [ nvmem-cell-names ]
> + nvmem-cell-names: [ nvmem-cells ]
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mixed-signal@10 {
> + compatible = "x-powers,ac200";
> + reg = <0x10>;
> + clocks = <&pwm 5>;
> + interrupt-parent = <&pio>;
> + interrupts = <1 20 IRQ_TYPE_LEVEL_LOW>;
> + #sound-dai-cells = <0>;
> + ac-ldoin-supply = <®_aldo2>;
> + tv-vcc-supply = <®_aldo2>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + tve_in: endpoint {
> + remote-endpoint = <&tcon_out_tve>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + tve_out: endpoint {
> + remote-endpoint = <&composite_in>;
> + };
> + };
> + };
> + };
> + };
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mixed-signal@10 {
> + compatible = "x-powers,ac200";
> + reg = <0x10>;
> + clocks = <&pwm 5>;
> + /* INTB is not connected. */
> + tv-vcc-supply = <®_aldo2>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + endpoint {
> + remote-endpoint = <&tcon_out_tve>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + endpoint {
> + remote-endpoint = <&composite_in>;
> + };
> + };
> + };
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a19da74d00c..419340093c9b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -29504,6 +29504,13 @@ F: drivers/net/wwan/
> F: include/linux/wwan.h
> F: include/uapi/linux/wwan.h
>
> +X-POWERS AC200 DRIVERS
> +M: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> +M: James Hilliard <james.hilliard1@xxxxxxxxx>
> +L: linux-sunxi@xxxxxxxxxxxxxxx
> +S: Maintained
> +F: Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
> +
> X-POWERS AXP288 PMIC DRIVERS
> M: Hans de Goede <hansg@xxxxxxxxxx>
> S: Maintained
>
> --
> 2.53.0
>
Attachment:
signature.asc
Description: PGP signature