Re: [PATCH 0/3 v4] delaytop: add delay max, timestamp and sorting for top latency analysis
From: Andrew Morton
Date: Tue Sep 08 2026 - 14:49:03 EST
On Tue, 8 Sep 2026 22:50:56 +0800 (CST) <wang.yaxin@xxxxxxxxxx> wrote:
> Previously delaytop only showed average delays. This patch adds:
>
> 1. delay_max fields to track the maximum delay value for each delay type
> (cpu, blkio, irq, swapin, freepages, thrashing, compact, wpcopy)
> per task.
>
> 2. The -t/--type option displays only the specified delay type with avg/max
> values side by side, allowing focused analysis:
> delaytop -t cpu # Show only CPU delay with avg/max
> delaytop -t wpcopy # Show Copy-on-Write delay with avg/max
>
> 3. Wall-clock timestamp when each maximum delay occurred, displayed in the
> MAX_TIMESTAMP column when using -t/--type option. This enables:
> - Identifying the time when a process experienced an abnormal delay max
> - Correlating delay max across multiple processes at the same timestamp
> - Cross-referencing with logs, traces, or other metrics at that time
>
> 4. When using -t/--type option, tasks are sorted by maximum delay value in
> descending order (largest delay first), enabling quick identification of
> top N processes with highest delay spikes.
>
We're missing the most important information: why make these changes?
Please update this [0/N] to explain the value of these changes. What
requirements are being satisfied? How will operators benefit from
these additions? How will you use them? Use cases. Things like that.
Also, AI review might have a found a few minor issues:
https://sashiko.dev/#/patchset/20260908225056266qjyBORsOReFvHLEQ3NKtR@xxxxxxxxxx
Thanks.