Re: [PATCH] clk: ultrarisc: Register DP1000 clock provider earlier

From: Brian Masney

Date: Tue Sep 08 2026 - 15:32:13 EST


Hi Jia,

On Mon, Sep 07, 2026 at 02:28:20PM +0800, Jia Wang wrote:
> On 2026-08-24 12:37 -0400, Brian Masney wrote:
> > On Thu, Aug 20, 2026 at 10:50:47AM +0800, Jia Wang wrote:
> > > The DP1000 PCIe and clock drivers both register at the device initcall
> > > level. Since the PCIe driver is linked first, its probe runs before the
> > > clock provider is available and defers.
> > >
> > > sysfb_init() runs at the same initcall level before deferred probes are
> > > retried. It claims the firmware framebuffer aperture, so the later PCIe
> > > host probe cannot allocate the overlapping prefetchable window and the
> > > GPU is not enumerated.
> > >
> > > Register the clock provider with subsys_initcall() when built in so PCIe
> > > host probing completes before sysfb_init(). Keep module builds using the
> > > normal module init and exit paths.
> > >
> > > Fixes: 3948a36be42b ("clk: ultrarisc: Add DP1000 clock driver")
> > > Signed-off-by: Jia Wang <wangjia@xxxxxxxxxxxxx>
> >
> > Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>
> >
> > I see this same pattern is also used by lots of qcom gcc drivers, 4
> > Renesas drivers, and a few other drivers.
> >
>
> A gentle ping on this fix.
>
> Please let me know if any changes or a resend are needed.

I just posted this series to reduce some boilerplate code across all of
the clk drivers:

https://lore.kernel.org/linux-clk/20260908-subsys_initcall-v1-0-cbccf4cd4288@xxxxxxxxxx/T/#t

Let's see what people think about this.

Brian