Re: [PATCH 05/13] srcutree: Honor is_atomic in check_init_srcu_struct()
From: Paul E. McKenney
Date: Tue Sep 08 2026 - 16:35:44 EST
On Mon, Sep 07, 2026 at 03:58:21PM +0800, Kunwu Chan wrote:
> From: Kunwu Chan <kunwu.chan@xxxxxxxxx>
>
> check_init_srcu_struct() drops its is_atomic argument, passing
> hard-coded false to init_srcu_struct_fields(). Pass is_atomic through
> instead.
>
> Signed-off-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>
Good catch, thank you!
I am folding this one into the following commit with attribution:
4e01d5320a2f ("srcutree: Suppress to-big transition for atomic SRCU")
This avoids potential bisection issues.
Thanx, Paul
> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 533607de5728..2af36db37fa9 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -522,7 +522,7 @@ static void check_init_srcu_struct(struct srcu_struct *ssp, bool is_atomic)
> raw_spin_unlock_irqrestore_rcu_node(ssp->srcu_sup, flags);
> return;
> }
> - init_srcu_struct_fields(ssp, true, false);
> + init_srcu_struct_fields(ssp, true, is_atomic);
> raw_spin_unlock_irqrestore_rcu_node(ssp->srcu_sup, flags);
> }
>
> --
> 2.43.0
>