Re: [PATCH net-next v2] ppp: pass private data to channel callbacks

[Jakub Kicinski]

On Sun,  6 Sep 2026 21:47:36 +0800 Qingfang Deng wrote:
> PPP channel callbacks receive struct ppp_channel only to retrieve the
> driver's private pointer. Pass that pointer directly instead.
> 
> This decouples channel callbacks from the public channel representation
> and prepares for making struct ppp_channel opaque, with allocation and
> lifetime managed by the generic PPP layer.

Not immediately obvious that this is a win. Having a callback op take
untyped pointer can be error prone. Also, subjectively, making types
opaque in C often leads to ugly and unnecessarily complex code.

This patch does not stand on its own, IMO, maybe you need to post the
entire series, and maybe rethink.
-- 
pw-bot: cr