Re: [PATCH 12/13] srcutree: Remove debug pr_alert()s

[Paul E. McKenney]

On Mon, Sep 07, 2026 at 03:58:28PM +0800, Kunwu Chan wrote:
> From: Kunwu Chan <kunwu.chan@xxxxxxxxx>
> 
> Remove the debug pr_alert()s from srcu_gp_start() and
> synchronize_srcu_atomic().
> 
> Signed-off-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>

Good point, we have gotten beyond where this debug code would be useful
(famous last words!).  I have folded this into the original commit with
attribution to prevent "&&&&" confusion.

							Thanx, Paul

> ---
>  kernel/rcu/srcutree.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index a93bf803e2f7..a016c93d65cb 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -916,7 +916,6 @@ static void srcu_gp_start(struct srcu_struct *ssp)
>  {
>  	int state;
>  
> -	/*&&&&*/pr_alert("%s() start: ->srcu_gp_seq: %lx ->srcu_gp_seq_needed: %lx\n", __func__, ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed);
>  	lockdep_assert_held(&ACCESS_PRIVATE(ssp->srcu_sup, lock));
>  	WARN_ON_ONCE(ULONG_CMP_GE(ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed));
>  	WRITE_ONCE(ssp->srcu_sup->srcu_gp_start, jiffies);
> @@ -2152,7 +2151,6 @@ void synchronize_srcu_atomic(struct srcu_struct *ssp)
>  	// OK, we really have to do it ourselves.  Start the grace period.
>  	non_block_start();  // We must not voluntarily block!
>  	smp_store_release(&sup->srcu_gp_seq_needed, srcu_state); // See srcu_funnel_gp_start().
> -	/*&&&&*/pr_alert("%s() start: ->srcu_gp_seq: %lx ->srcu_gp_seq_needed: %lx\n", __func__, ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed);
>  	ASSERT_EXCLUSIVE_WRITER(ssp->srcu_sup->srcu_gp_seq);
>  	srcu_gp_start(ssp);
>  	raw_spin_unlock_irq_rcu_node(sup);
> @@ -2208,7 +2206,6 @@ void synchronize_srcu_atomic(struct srcu_struct *ssp)
>  		cpu_relax();
>  		srcu_advance_state(ssp, true);
>  	}
> -	/*&&&&*/pr_alert("%s() end: ->srcu_gp_seq: %lx ->srcu_gp_seq_needed: %lx\n", __func__, ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed);
>  	ASSERT_EXCLUSIVE_WRITER(sup->srcu_atomic_gp_flag);
>  	atomic_set_release(&sup->srcu_atomic_gp_flag, 0);
>  	preempt_enable();
> -- 
> 2.43.0
>