RE: [PATCH v3 13/13] arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3 13/13] arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263
> 
> Hi Biju,
> 
> On Wed, 26 Aug 2026 at 19:49, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add a Device Tree overlay (r9a08g046l48-smarc-lvds-ite6263.dtso) for
> > the RZ/G3L (R9A08G046) SMARC EVK board to support LVDS-to-HDMI output
> > via the ITE 6263 HDMI transmitter.
> >
> > The overlay enables the LVDS controller and the display unit
> > (DU/LCDC), and configures the ITE6263 on I2C2.
> >
> > Update the Makefile to build the overlay as both a standalone .dtbo
> > and a composite .dtb (base DTB + overlay).
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-lvds-ite6263.dtso
> > @@ -0,0 +1,104 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> Any chance this can be "(GPL-2.0-only OR BSD-2-Clause)", like all already existing
> arch/arm64/boot/dts/renesas/r9a08g046* files?

Ooops, will fix this.

> 
> > +/*
> > + * Device Tree overlay for the RZ/G3L SMARC EVK with ITE6263
> > + * connected to LVDS and LCDC enabled.
> > + *
> > + * Copyright (C) 2026 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/pinctrl/renesas,r9a08g046-pinctrl.h>
> > +
> > +&{/} {
> > +       lvds-to-hdmi-out {
> > +               compatible = "hdmi-connector";
> > +               type = "d";
> > +
> > +               port {
> > +                       lvds_to_hdmi_con_out: endpoint {
> > +                               remote-endpoint = <&it6263_out>;
> > +                       };
> > +               };
> 
> No DDC?

The driver uses parent i2c bus as ddc-i2c-bus. That is the reason not added.


> 
> > +       };
> > +
> > +       reg_1v8: regulator-1v8 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "fixed-1.8V";
> > +               regulator-min-microvolt = <1800000>;
> > +               regulator-max-microvolt = <1800000>;
> > +               regulator-boot-on;
> > +               regulator-always-on;
> > +       };
> > +
> > +       reg_3v3: regulator-3v3 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "fixed-3.3V";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +               regulator-boot-on;
> > +               regulator-always-on;
> > +       };
> 
> Any specific reason you cannot just reuse the existing &reg_1p8v and &reg_3p3v?

Ok, will drop these.

> 
> > +};
> > +
> > +&du {
> > +       status = "okay";
> > +};
> > +
> > +&i2c2 {
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +
> > +       it6263: it6263@4c {
> 
> hdmi@4c
Ok.

> 
> > +               compatible = "ite,it6263";
> > +               reg = <0x4c>;
> > +               data-mapping = "vesa-24";
> > +               ivdd-supply = <&reg_1v8>;
> > +               ovdd-supply = <&reg_3v3>;
> > +               txavcc18-supply = <&reg_1v8>;
> > +               txavcc33-supply = <&reg_3v3>;
> > +               pvcc1-supply = <&reg_1v8>;
> > +               pvcc2-supply = <&reg_1v8>;
> > +               avcc-supply = <&reg_3v3>;
> > +               anvdd-supply = <&reg_1v8>;
> > +               apvdd-supply = <&reg_1v8>;
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       port@0 {
> > +                               reg = <0>;
> > +                               bridge_in: endpoint {
> > +                                       remote-endpoint = <&lvds_out>;
> > +                               };
> > +                       };
> > +
> > +                       port@2 {
> > +                               reg = <2>;
> > +                               it6263_out: endpoint {
> > +                                       remote-endpoint = <&lvds_to_hdmi_con_out>;
> > +                               };
> > +                       };
> > +               };
> 
> No audio?

Binding describes audio port, but ITE6263 driver supports only video mode compared to
both Audio/Video support on ADV7535 driver.

I will add audio entries once we have driver support.
Hope it is ok for you?

Cheers,
Biju

> 
> > +       };
> > +};
> 
> The rest LGTM.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds