Re: [PATCH v4 3/3] i3c: add i3cdev module to expose i3c dev in /dev

[Sam Agazaryan]

On Mon, Sep 7, 2026 at 7:42 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Sep 06, 2026 at 08:27:47PM +0000, Sam Agazaryan wrote:
> > +/**
> > + * struct i3c_ioc_priv_xfer - I3C SDR ioctl private transfer
> > + * @data: Holds pointer to userspace buffer with transmit data.
> > + * @len: Length of data buffer buffers, in bytes.
> > + * @rnw: encodes the transfer direction. true for a read, false for a write
>
> You do not describe the "pad" variable.

I'll add a description for "pad".

> And why not call "rnw" "direction"?

I'll update "rnw" to "direction" since this is exposed to userland.

> > + */
> > +struct i3c_ioc_priv_xfer {
> > +     __u64 data;
> > +     __u16 len;
> > +     __u8 rnw;
> > +     __u8 pad[5];
>
> You do not enforce that pad[5] MUST be set to all 0.

I'll add a zero check against the padding to address this.

The next revision of the patchset will include these updates.

Thanks,
Sam