Re: [PATCH 4/6] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8140 compatible

[Yureka Lilian]

On 9/9/26 09:32, Krzysztof Kozlowski wrote:
> On 09/09/2026 09:31, Krzysztof Kozlowski wrote:
> > On Sat, Sep 05, 2026 at 04:25:36PM +0800, Nick Chan wrote:
> > > Yureka Lilian 於 2026/9/5 凌晨3:49 寫道:
> > > > The Apple t8140 (A18 Pro) SoC uses an AIC3 as interrupt controller, same as
> > > > the M1-M4 SoCs.
> > > >
> > > > Signed-off-by: Yureka Lilian <yureka@xxxxxxxxxxxxxx>
> > > > ---
> > > >   Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> > > > index 1cb886785173..e3cadc5ad39d 100644
> > > > --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> > > > @@ -46,6 +46,7 @@ properties:
> > > >                 - apple,t6030-aic3
> > > >                 - apple,t6031-aic3
> > > >                 - apple,t8132-aic3
> > > > +              - apple,t8140-aic3
> > > the title should be "... Add t8140 compatible" describing the hardware corresponding
> > > to the added compatible since the compatible being added is not "apple,t8140".
> > Commit msg is correct, it does exactly what you wrote, no?
> >
> > > (Alternatively, if you mention the compatible in title, say "...Add apple,t8140-aic3" as
> > > "compatible" is already implied)
> > That would be repeating diff, so not really helpful.
>
> Ah, you meant the subject of the patch...
>
>
> Best regards,
> Krzysztof


That's how I parsed it too. Removed the "apple," from the subject, so 
it's just "dt-bindings: interrupt-controller: apple,aic2: Add t8140 
compatible".


- Yureka