Re: [PATCH v4 17/17] mm/huge_memory: drop the redundant mapping argument of __split_frozen_folio
From: Kiryl Shutsemau
Date: Wed Sep 09 2026 - 04:39:44 EST
On Tue, Sep 08, 2026 at 02:12:21AM +0800, Kairui Song via B4 Relay wrote:
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> The mapping parameter only served as a non-NULL check to detect
> whether page cache entries need updating. The xa_state pointer
> conveys exactly the same information: the anon split helper passes
> NULL and the file split helper passes &xas, which is non-NULL iff
> the folio is in the page cache.
>
> Use the xas pointer instead and drop the parameter, along with its
> kerneldoc entry.
>
> Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
> Reviewed-by: Yeoreum Yun <yeoreum.yun@xxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@xxxxxxxxxx>
--
Kiryl Shutsemau / Kirill A. Shutemov