Re: [PATCH v2 2/2] firmware: arm_scmi: Don't reuse raw xfers with async_done still armed

From: Cristian Marussi

Date: Wed Sep 09 2026 - 07:34:51 EST


On Wed, Sep 09, 2026 at 04:32:28AM +0000, Roland Dreier via B4 Relay wrote:
> From: Roland Dreier <rolanddreier@xxxxxxxxxx>
>
> In SCMI raw mode, scmi_xfer_raw_worker() releases the xfer before
> releasing the waiter that disarms xfer->async_done, and scmi_xfer_get()
> does not clear async_done when it hands out a recycled xfer. A concurrent
> transaction can therefore pick up the xfer while it still points at the
> old waiter's completion, so:

Hi,

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
Tested-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Thanks,
Cristian