Re: [PATCH v17 03/20] KVM: arm64: Track the type of VM in kvm_arch
From: Fuad Tabba
Date: Wed Sep 09 2026 - 07:41:00 EST
Hi Suzuki,
On Tue, 8 Sept 2026 at 17:23, Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote:
>
> KVM arm64 has different types of VMs with all the different modes in which the
> hypervisor code can be run. e.g., VHE, nVHE, PKVM etc. Then there is protected
> VM and normal VMs with PKVM. We might soon add other types, e.g., Arm CCA Realm.
> So in an effort to make the handling of these different types of VMs a bit more
> friendlier to the eyes, add a VM flavor to the kvm_arch and we could then add
nit: "friendlier"
> handlers for different operations based on the VM type.
>
> Keep the flavor initialisation at the beginning to allow for the detection
> early enough and fail out on any unsupported requests. (e.g., protected on !PKVM)
In the commit msg and later in the code (not in the enum though), can
you please spell pKVM with a lower-case p?
Reviewed-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>
Cheers,
/fuad