Re: [PATCHv4 3/4] EDAC/altera: Fix code leak on dci allocation failure

From: Dinh Nguyen

Date: Wed Sep 09 2026 - 12:57:58 EST




On 9/9/26 09:33, Rounak Das wrote:
Hi Dinh,

if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL))
+ edac_device_free_ctl_info(dci);
return -ENOMEM;
+ }

This file will not compile since the braces are wrong, there is no starting {.

Also, another thing that I noticed is that 2/4's Fixes tag is missing
its closing
quote after "probe()".

Argh..Thank you for catching that!


I will rebase and resend my of_node_put fix once this series lands.

Dinh