Re: [PATCH v3 0/2] ASoC: tas2783-sdw: fix the read-only Control handling

From: Mark Brown

Date: Wed Sep 09 2026 - 13:42:48 EST


On Sat, 15 Aug 2026 14:40:00 +0300, Andrey Golovko wrote:
> ASoC: tas2783-sdw: fix the read-only Control handling
>
> The 1/2 of v2 is in for-7.3 as 0c7aeb0f5ece, so this is the rest of it,
> rebased on that, with one more patch in front.
>
> Mark asked whether marking the read-only Controls volatile works for
> multi-byte reads. It does not, on its own. Twenty of the Controls that
> patch marks volatile are wider than one byte: nineteen of four - the
> Latency of FU23, FU26 and FU127, XU22 0x06, SAPU29 0x05, PPU21 and PPU26
> 0x06, the 0x08 Control of IT21, IT26, IT28, IT29, OT23, OT24, OT25, OT28
> and OT127, MU26 0x06, MFPU21 and MFPU26 0x08 - and XU22 0x07 of two.
> With val_bits = 8 the MBQ layer refuses each of them before anything
> reaches the bus, so the patch on its own would turn a read that used to
> be answered from the cache into -EINVAL. What the cache answered was
> the placeholder from tas2783_reg_default[] rather than anything the
> device had said, and the driver performs no register reads at all, so
> nothing in tree can tell the difference today - but -EINVAL is not what
> the patch should leave behind.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/2] ASoC: tas2783-sdw: make multi-byte MBQ registers reachable
https://git.kernel.org/broonie/sound/c/3e56757584d6
[2/2] ASoC: tas2783-sdw: do not cache read-only Controls
https://git.kernel.org/broonie/sound/c/f4ffa3820949

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark