Re: [PATCH] crypto: ccp: psp-sev.h: clean up kernel-doc warnings
From: Randy Dunlap
Date: Wed Sep 09 2026 - 14:19:49 EST
Hi Tom,
On 9/9/26 7:57 AM, Tom Lendacky wrote:
>> -/**
>> +/*
>> * SEV platform and guest management commands
>> */
>> enum sev_cmd {
>> @@ -162,7 +162,9 @@ enum sev_cmd {
>> */
>> struct sev_data_init {
>> u32 flags; /* In */
>> + /* private: */
>> u32 reserved; /* In */
> I noticed that, for example, struct sev_snp_tcb_version_genoa_milan has
> the reserved field as part of the kernel-doc, which seems to eliminate
> the need for the "/* private: */" and "/* public: */" comments. Would it
> be better to instead just add the reserved fields to the kernel doc?
Is that your preference? I can do it either way; I don't have
a strong preference for either.
thanks.
--
~Randy