Re: [PATCH v7 1/6] dt-bindings: leds: leds-cpcap: convert to DT schema
From: Svyatoslav Ryhel
Date: Wed Sep 09 2026 - 14:20:56 EST
ср, 9 вер. 2026 р. о 19:27 Lee Jones <lee@xxxxxxxxxx> пише:
>
> On Tue, 21 Jul 2026, Rob Herring (Arm) wrote:
>
> >
> > On Tue, 21 Jul 2026 12:56:48 +0300, Svyatoslav Ryhel wrote:
> > > Convert LEDs devicetree bindings for the Motorola CPCAP MFD from TXT to
> > > YAML format. This patch does not change any functionality; the bindings
> > > remain the same.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > > ---
> > > .../devicetree/bindings/leds/leds-cpcap.txt | 29 -------------
> > > .../bindings/leds/motorola,cpcap-leds.yaml | 42 +++++++++++++++++++
> > > 2 files changed, 42 insertions(+), 29 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/leds/leds-cpcap.txt
> > > create mode 100644 Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> >
> >
> > doc reference errors (make refcheckdocs):
> > Warning: Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
> > Warning: Documentation/devicetree/bindings/mfd/motorola-cpcap.txt references a file that doesn't exist: Documentation/devicetree/bindings/leds/leds-cpcap.txt
> > Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml: Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
> > Documentation/devicetree/bindings/mfd/motorola-cpcap.txt: Documentation/devicetree/bindings/leds/leds-cpcap.txt
> >
> > See https://patchwork.kernel.org/project/devicetree/patch/20260721095654.429346-2-clamor95@xxxxxxxxx
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
>
> This one.
>
As you can see only complain is that reference in the leds yaml to
Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml does not
exist. All cpcap cell bindings were converted one by one as separate
commits, so this is natural since motorola,cpcap.yaml will be
converted last and patch doing this is included in the series. It does
not bring any regressions in yaml and dt schema checks.
> --
> Lee Jones