Re: [PATCH] media: synopsys: hdmirx: Remove redundant dev_err_probe()

[Dmitry Osipenko]

On 9/7/26 10:52, Amin Gattout wrote:
> The devm_request_threaded_irq() function now automatically logs detailed
> error messages on failure. This eliminates the need for driver-specific
> dev_err_probe() calls that print generic messages.
> 
> Signed-off-by: Amin Gattout <amin.gattout@xxxxxxxxx>
> ---
>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 25f8ca0d6d94..b456138c381a 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -2595,10 +2595,8 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,
>  	ret = devm_request_threaded_irq(dev, irq, NULL, hdmirx_dma_irq_handler,
>  					IRQF_ONESHOT, "rk_hdmirx-dma",
>  					hdmirx_dev);
> -	if (ret) {
> -		dev_err_probe(dev, ret, "failed to request dma irq\n");
> +	if (ret)
>  		return ret;
> -	}
>  
>  	irq = gpiod_to_irq(hdmirx_dev->detect_5v_gpio);
>  	if (irq < 0) {
> 
> ---
> base-commit: df2908090cda368b01ff43709f51890076c56157
> change-id: 20260907-snps_hdmirx-7a30ccc56a49
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@xxxxxxxxx>
> 

Acked-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>

-- 
Best regards,
Dmitry