Re: [PATCH net-next v3 5/6] net: dsa: motorcomm: Fix MIB synchronization

From: David Yang

Date: Wed Sep 09 2026 - 15:52:04 EST


On Wed, Sep 9, 2026 at 11:16 PM <netdev-bot+sashiko@xxxxxxxxxx> wrote:

> [Severity: Medium]
> Should this carry a Fixes: tag? The unsynchronized 64-bit MIB accessors
> and .get_stats64() came in with 186623f4aa724c ("net: dsa: yt921x: Add
> support for Motorcomm YT921x"), so this is a fix to already-merged driver
> code.
>
> Related to that, the fix does not look self-contained: the counter type
> conversion lives in the preceding patch "net: dsa: motorcomm: Use
> u64_stats_t for MIB stats", whose changelog says "u64_stats_sync will be
> equipped in the next commit", and this commit also builds on "Rename MIB
> stuffs", "Split MIB buffers" and "Split MIB module".
>
> Since neither commit alone closes the tearing window, how would a stable
> backport of this fix be done without pulling in the whole refactor series?

This is a low-risk issue and does not affect control paths. Also it
would be quite impossible to backport it since the whole series is to
fix this and it would require major refactor on the struct.