Re: [PATCH] power: supply: s2mu005-battery: return errors from dev_err_probe() in probe
From: Sebastian Reichel
Date: Wed Sep 09 2026 - 17:05:20 EST
On Thu, 27 Aug 2026 10:05:39 +0800, Zongmin Zhou wrote:
> s2mu005_fg_i2c_probe() calls dev_err_probe() when devm_mutex_init() or
> devm_request_threaded_irq() fails, but drops the return value and
> carries on, finally returning 0. A failed probe is then reported as a
> success: the device stays registered with an uninitialized mutex and
> without its IRQ handler installed.
>
> Return the error from dev_err_probe() in both places so that the probe
> fails and the driver core logs the error state properly.
>
> [...]
Applied, thanks!
[1/1] power: supply: s2mu005-battery: return errors from dev_err_probe() in probe
commit: d5146fe3468703d82087270eb18bac81c15c10a6
Best regards,
--
Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>