Re: [PATCH] power: supply: bq24190_charger: use the wake irq API

From: Sebastian Reichel

Date: Wed Sep 09 2026 - 17:17:28 EST



On Tue, 08 Sep 2026 00:35:58 -0500, Ryan Brue wrote:
> bq24190_probe() calls enable_irq_wake() on the charger interrupt and
> never calls disable_irq_wake(). That is wrong in three ways.
>
> It is unbalanced. free_irq() does not touch desc->wake_depth -- only
> irq_set_irq_wake() does -- so after the driver is unbound the descriptor
> is still one wake reference deep and the irqchip is still configured for
> wake, forever, for an interrupt nobody owns any more.
>
> [...]

Applied, thanks!

[1/1] power: supply: bq24190_charger: use the wake irq API
commit: 00465cb99af254dee479be51b793a49a0af442bf

Best regards,
--
Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>