Re: [PATCH v2 3/4] bpftool: Add explicitly sequenced -lzstd to libbfd feature fallback

[bot+bpf-ci]

> bpftool: Add explicitly sequenced -lzstd to libbfd feature fallback
>
> Distributions like Fedora currently ship a statically compiled binutils
> libbfd that natively depends on zstd to decompress sections (e.g.
> undefined reference to 'ZSTD_decompress').
>
> Extend the newly supplemented libbfd-liberty-z-zstd feature probe into
> bpftool's Makefile so it can natively build against static binutils
> distributions.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> Assisted-by: Antigravity:gemini-3.1-pro

This isn't a bug, but the subject line uses the phrase "explicitly
sequenced" which doesn't appear to describe what the patch does. Looking at
the diff, the patch adds libbfd-liberty-z-zstd to FEATURE_TESTS and
FEATURE_DISPLAY, then appends a new fallback branch with '-lz -lzstd' to
the existing cascade.

Similarly, "Extend the newly supplemented ... probe into bpftool's Makefile"
is a bit indirect. The patch adds the probe to FEATURE_TESTS and appends the
matching link flags to the fallback chain.

Also, "natively" appears twice ("natively depends on zstd", "natively build
against static binutils") but doesn't add meaning to either phrase.

Would a more direct subject such as "bpftool: Use libbfd-liberty-z-zstd
feature in the libbfd fallback chain" describe the change more clearly, and
could the body state simply that the new probe is added to FEATURE_TESTS
and a matching '-lz -lzstd' branch appended to the fallback?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/34404437407