Re: [PATCH v20 1/9] PCI/AER: Introduce AER-CXL protocol error kfifo

From: Jonathan Cameron

Date: Wed Sep 09 2026 - 18:02:56 EST


Hi Terry,

> >>
> >> A subsequent patch wires cxl_forward_error() into handle_error_source().
> >>
> >> Add MAINTAINERS entries for aer_cxl_vh.c and aer_cxl_rch.c under the CXL
> >> entry.
> >
> > I couldn't immediately find any discussion about switching away from panic
> > on a kfifo overflow. Was there a reply to an earlier version with a
> > discussion of that? I'm not against the change but a 'why'
> > here would be good to have.
> >
>
> The driver panics on kfifo full error during UCE enqueue. This was recommended by you and
> Richard. Changes are at the link below in cxl_forward_error():
> https://lore.kernel.org/linux-cxl/20260902133933.2992457-2-terry.bowman@xxxxxxx/
>
Panic on UCE is a given and correct. I ran the not panic on correctable via some
of our folk and they were fine with it (at least so far!). I just saw that
you'd stopped panic on this as part of the change log and wondered why.

Not a problem, just following the breadcrumbs!

Jonathan