Re: [PATCH v2] i3c: master: amd: Report direct CCC read length in payload.actual_len
From: Frank Li
Date: Wed Sep 09 2026 - 18:06:17 EST
On Tue, Sep 08, 2026 at 04:42:07PM +0530, Shubham Patil wrote:
> The I3C core expects master drivers to leave payload.len unchanged and
> report the number of bytes received on GET CCCs via payload.actual_len.
> The AMD driver was overwriting payload.len after direct read CCCs.
>
> Set payload.actual_len from the directed command's rx_actual in
> xi3c_master_send_direct_ccc_cmd() instead of modifying payload.len.
>
> Fixes:629a6ddd1d9a ("i3c: master: Add driver for AMD AXI
> I3C master controller")
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@xxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Changes in v2:
> - Added Fixes tag
> ---
> drivers/i3c/master/amd-i3c-master.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master/amd-i3c-master.c b/drivers/i3c/master/amd-i3c-master.c
> index ef5ad5abb788..f205aa06f9b8 100644
> --- a/drivers/i3c/master/amd-i3c-master.c
> +++ b/drivers/i3c/master/amd-i3c-master.c
> @@ -806,8 +806,8 @@ static int xi3c_master_send_direct_ccc_cmd(struct xi3c_master *master,
>
> /* Report actual byte count so the core sees the right length on short reads */
> if (!ret && ccc->rnw)
> - ccc->dests[0].payload.len = min(xfer->cmds[1].rx_actual,
> - ccc->dests[0].payload.len);
> + ccc->dests[0].payload.actual_len = min(xfer->cmds[1].rx_actual,
> + ccc->dests[0].payload.len);
>
> return ret;
> }
> --
> 2.34.1
>