Re: [PATCHv2 1/4] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API

[Rosen Penev]

On Tue, Sep 8, 2026 at 11:00 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 06/09/2026 20:34, Rosen Penev wrote:
> > On Tue, Sep 1, 2026 at 8:29 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >>>       dev_set_drvdata(&dev->dev, NULL);
> >>> @@ -204,9 +202,21 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
> >>>       int ret = 0;
> >>>       int version, banks;
> >>>       void __iomem *addr;
> >>> +     int nand_irq;
> >>> +     int irq;
> >>
> >> Why do you need the intermediate variables?
> > In order to call platform_get_irq before any allocation happens in probe.
> >>
>
> But allocation is the first thing the probe is doing.
We're going in circles.

It's better to return -EPROBE_DEFER as early as possible to avoid
doing anything.
>
> Best regards,
> Krzysztof